Add support for derivatives. Improve error handling, logging, and build process. by yahiaali · Pull Request #3 · brandbci/brand

yahiaali · 2024-10-31T06:07:46Z

This PR adds in a multitude of feature that have been used internally for the past few months. The primary changes are as follows:

supervisor and booter can now run derivatives, which are scripts that can be added on to the end of a graph or executed on their own. These are typically used for data export or model training.
Log messages are now saved to a Redis stream
The Makefile now has an option to build only the nodes that are being used in a particular graph

Moving some NWB configuration parameters to the graph for flexibility, updated documentation

Keep supervisor running when an error occurs in command execution

…for nodes not crashing during initialization

Update exportNWB to read source node from 'derivates' secion of graph YAML

Hotfix: booter host ip arg flag changed from 'hs' to 'i'

…ervisor.terminate()

…se supervisor to think they crashed

…ative name

Fix for stop graph and save blocking issue

Verbose command edit

…visor

cpandar · 2026-08-26T14:32:10Z

@mirigotti @yahiaali any reason not to merge this?

cpandar · 2026-08-26T14:32:52Z

@tscizzlebg @davansin any thoughts?

tscizzlebg · 2026-08-26T16:55:51Z

I did a diff between this PR's resulting repo, and our current brand-core repo. It does seem that this PR mostly just brings brandbci/brand up to speed with what BG has been using successfully already. However, it's not exact. There's a few more recent changes in brand-core that are not included in this PR (e.g., a new graph status "stopping", a new arg to derivatives "delay_sec", some documentation updates, some brand.c function return type changes). Might as well get all the way up-to-date? (But if that's enough friction to slow things down, then please ignore.)
I have not kept close enough track to backward-compatibility, like if there are minor one-off things each BG site had to do when any of these changes were made originally. So my only answer to the question "any reason not to merge this?" is a follow-up question: @mirigotti @yahiaali do you know if current BRAND users will have to do anything extra to adopt this new version, besides just pull the code?

mirigotti and others added 30 commits August 29, 2022 16:58

Merge pull request #69 from snel-repo/nwb_update

5972124

Moving some NWB configuration parameters to the graph for flexibility, updated documentation

Merge branch 'dev' into paper_dev

d53ad32

Adding time import to supervisor

a3f19e4

Merge pull request #68 from snel-repo/paper_dev

ff546c4

Keep supervisor running when an error occurs in command execution

Adding graph error handling to supervisor

27a21d0

Removing unused supervisor functions

ee5b028

Added redis-server error handling (supervisor exits if error)

4c395ea

Adding log-level argument to supervisor

361adcb

Adding more error handling after testing

4741473

Moving exceptions to brand lib directory

da5c785

Adding supervisor_status update feature

894e106

Adding NodeError exception and adding exception scenario that checks …

9ced333

…for nodes not crashing during initialization

Adding error handling for booter

440d802

Update exportNWB to load source node from derivatives section

2f6da09

updated NWB guidelines

fe1f049

Fixing booter error handling on supervisor

3a35664

Updating exportNWB doc with additional details about source_node

d49653f

Removing unused function from exportNWB

b91e6d3

Merge pull request #71 from snel-repo/nwb_source_node_update

8d38b77

Update exportNWB to read source node from 'derivates' secion of graph YAML

Merge branch 'dev' into error_handling_dev

f057dc2

Adding tracebacks to exception messages, booter untested

601cf7f

Validated functional booter error logging

f0e6b40

Updating documentation related to exception handling

c717052

Fixed booter host ip arg flag from 'hs' to 'i'

163d2b7

Removing unused booter imports

bdb6893

Merge pull request #72 from snel-repo/booter_host_hotfix

cdc8165

Hotfix: booter host ip arg flag changed from 'hs' to 'i'

Fixing checkBooter to not ignore 'graph failed' messages

e956b59

Merge branch 'dev' into error_handling_dev

0005fd7

Fixing redis connection error to directly exit instead of calling sup…

eae6208

…ervisor.terminate()

Fixing supervisor bug where nodes that launched too quickly would cau…

10eeb44

…se supervisor to think they crashed

theForerunner and others added 26 commits June 4, 2024 13:07

Simplified stop graph code

387e184

Moved do_save back in front of do_derivative and changed log msg

e8deb04

Elevate log level if not all booters are handling stop_graph message

8c81672

In progress on verbose_command in supervisor and booter

37004b8

Added verbose_command to booter

75058b7

When booter gets new supergraph, dont print every node name and deriv…

ae1be19

…ative name

Make verbose not treated as a node nickname

11bd071

Changed verbose_command logic

a579de9

Changed indents

2a4d08b

Changed indents

7cb77d1

Fixed warning when only verbose_global is received

93155ad

Added logging on default log level mod

915df0e

Modifications according to Tyler's suggestions

275e0f1

Fixed command check error

f7fadce

Rename verbose to log_level

4202ba8

Make booter always log receive command w/ default log level

53ccb00

log received command at command log level

6487cb6

Merge pull request #150 from snel-repo/stop-and-save-fix

ce00641

Fix for stop graph and save blocking issue

Merge branch 'dev' with 'verbose-command-edit'

0ad55b1

Merge pull request #154 from snel-repo/verbose-command-edit

af55935

Verbose command edit

Merge remote-tracking branch 'upstream/dev' into dev

a80ba87

Complete merge of brand.c code

3432f2d

Add option to bind redis-server to multiple interfaces

b07de55

Start booter nodes using the IP address and port of booter, not super…

cf6f60e

…visor

Merge pull request #155 from snel-repo/bind_multi

efc33e6

Merge remote-tracking branch 'private/dev' into dev

ff1ae92

yahiaali marked this pull request as ready for review February 19, 2025 22:03

Navigation Menu

Uh oh!

Add support for derivatives. Improve error handling, logging, and build process. - #3

Add support for derivatives. Improve error handling, logging, and build process.#3
yahiaali wants to merge 861 commits into
mainfrom
dev

yahiaali commented Oct 31, 2024 •

edited

Loading

Uh oh!

cpandar commented Aug 26, 2026

Uh oh!

cpandar commented Aug 26, 2026

Uh oh!

tscizzlebg commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

yahiaali commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cpandar commented Aug 26, 2026

Uh oh!

cpandar commented Aug 26, 2026

Uh oh!

tscizzlebg commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

yahiaali commented Oct 31, 2024 •

edited

Loading